Skip to content

Add MSRV to more lints specified in #6097 #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 3 commits into from
Dec 11, 2020
Merged

Add MSRV to more lints specified in #6097 #6424

bors merged 3 commits into from
Dec 11, 2020

Conversation

@suyashb95
Copy link
Contributor

@suyashb95 suyashb95 commented Dec 5, 2020 •
edited by flip1995
Loading

add MSRV to more lints specified in #6097
add instructions for adding msrv in other lints
update tests

  • redundant_field_names requires Rust 1.17 due to suggest feature stablized in that version.
  • redundant_static_lifetimes requires Rust 1.17 due to suggest feature stablized in that version.
  • filter_map_next requires Rust 1.30 due to suggest Iterator::find_map.
  • checked_conversions requires Rust 1.34 due to suggest TryFrom.
  • match_like_matches_macro requires Rust 1.42 due to suggest matches!. Addressed in Add support for minimum supported rust version #6201
  • manual_strip requires Rust 1.45 due to suggest str::{strip_prefix, strip_suffix}. Addressed in Add support for minimum supported rust version #6201
  • option_as_ref_deref requires Rust 1.40 due to suggest Option::{as_deref, as_deref_mut}. Addressed in Add support for minimum supported rust version #6201
  • manual_non_exhaustive requires Rust 1.40 due to suggest #[non_exhaustive]. Addressed in Add support for minimum supported rust version #6201
  • manual_range_contains requires Rust 1.35 due to suggest Range*::contains.
  • use_self requires Rust 1.37 due to suggest Self::Variant on enum.
  • mem_replace_with_default requires Rust 1.40 due to suggest mem::take.
  • map_unwrap_or requires Rust 1.41 due to suggest Result::{map_or, map_or_else}.
  • missing_const_for_fn requires Rust 1.46 due to match/if/loop in const fn needs that version.

changelog: Add MSRV config to more lints. ^This is now the complete list, AFAWK

@rust-highfive
Copy link

rust-highfive commented Dec 5, 2020

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 5, 2020
@suyashb95
Copy link
Contributor Author

suyashb95 commented Dec 5, 2020

r? @flip1995

@rust-highfive rust-highfive assigned flip1995 and unassigned llogiq Dec 5, 2020
@flip1995
Copy link
Member

flip1995 commented Dec 5, 2020

LGTM. There are some extra blank lines added (mostly before the if meets_msrv conditions.

Do you want to add the rest of the lints in this PR or split this up?

@suyashb95
Copy link
Contributor Author

suyashb95 commented Dec 5, 2020

@flip1995 think I'll add all the lints in this one along with some instructions for introducing msrv for other lints. I'll run cargo dev fmt before I finish this up

@flip1995
Copy link
Member

flip1995 commented Dec 5, 2020 •
edited
Loading

Great! Please ping me, when you're done, so I don't miss it

@suyashb95
Copy link
Contributor Author

suyashb95 commented Dec 8, 2020

@flip1995 could you please review these changes?

flip1995
flip1995 reviewed Dec 8, 2020
View reviewed changes
flip1995
flip1995 reviewed Dec 8, 2020
View reviewed changes
@suyashb95 suyashb95 force-pushed the master branch 2 times, most recently from 4e3ec90 to 01894ee Compare December 9, 2020 15:17
flip1995
flip1995 reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but something is going on with manual_strip

flip1995
flip1995 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you squash some of the commits, please? There are 3 or 4 formatting commits.

@suyashb95
Copy link
Contributor Author

suyashb95 commented Dec 11, 2020

Thanks! Can you squash some of the commits, please? There are 3 or 4 formatting commits.

Just did! Are we good to merge this?

@flip1995 flip1995 changed the title [WIP] add MSRV to more lints specified in #6097 Add MSRV to more lints specified in #6097 Dec 11, 2020
@flip1995
Copy link
Member

flip1995 commented Dec 11, 2020

Thanks! I think we can start writing up the internals blog post 👍

@bors r+

@bors
Copy link
Contributor

bors commented Dec 11, 2020

📌 Commit 9f27b74 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Dec 11, 2020

⌛ Testing commit 9f27b74 with merge 27fd6ed...

@bors
Copy link
Contributor

bors commented Dec 11, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 27fd6ed to master...

@bors bors merged commit 27fd6ed into rust-lang:master Dec 11, 2020
@bors bors mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suyashb95 @rust-highfive @flip1995 @bors @llogiq